Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin sync with no address specified #2392

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

gammazero
Copy link
Collaborator

The admin sync command causes panic when no address is given. Fixed by avoiding nil multiaddr.

Update go-libp2p to fix timer leak.

Fixes #2388

The admin sync command causes panic when no address is given. Fixed by avoiding nil multiaddr.

Update go-libp2p to fix timer leak.

Fixes #2388
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0c74788) 48.06% compared to head (d787d52) 48.19%.

Files Patch % Lines
server/admin/handler.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
+ Coverage   48.06%   48.19%   +0.12%     
==========================================
  Files          82       82              
  Lines        9786     9788       +2     
==========================================
+ Hits         4704     4717      +13     
+ Misses       4548     4539       -9     
+ Partials      534      532       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Suggested version: v0.8.8

Comparing to: v0.8.7 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
required module github.com/kataras/iris/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon. Please update to @latest
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.8.8

gocompat says:

Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@gammazero gammazero merged commit 27f38ba into main Nov 15, 2023
11 checks passed
@gammazero gammazero deleted the fix-sync-without-addr branch November 15, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync without addr causes panic
2 participants