Skip to content

Commit

Permalink
Use 'no switchport' as default on Arista EOS LAG interfaces
Browse files Browse the repository at this point in the history
Replaces #1889 and #1886, fixes #1884, #1883
  • Loading branch information
ipspace committed Feb 7, 2025
1 parent 6c61ce0 commit bc79d3e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
2 changes: 1 addition & 1 deletion netsim/ansible/templates/initial/eos.j2
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ interface {{ mgmt.ifname|default('Management1') }}
!
{% for l in netlab_interfaces %}
interface {{ l.ifname }}
{% if l.virtual_interface is not defined %}
{% if l.virtual_interface is not defined or l.type in ['lag'] %}
no switchport
{% endif %}
{% if l.vrf is defined %}
Expand Down
12 changes: 0 additions & 12 deletions netsim/devices/eos.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,6 @@ def check_dhcp_clients(node: Box, topology: Box) -> None:
category=log.IncorrectType,
module='quirks')

def check_l3_lag(node: Box, topology: Box) -> None:
for intf in node.interfaces:
if intf.type != 'lag':
continue
if intf.get('ipv4',False) is not False or intf.get('ipv6',False) is not False:
log.error(
f"Interface {intf.ifname} on Arista EOS node {node.name} cannot have IPv4/IPv6 addresses",
category=log.IncorrectType,
module='quirks')

def configure_ceos_attributes(node: Box, topology: Box) -> None:
serialnumber = node.eos.get('serialnumber',None)
systemmacaddr = node.eos.get('systemmacaddr',None)
Expand Down Expand Up @@ -135,8 +125,6 @@ def device_quirks(self, node: Box, topology: Box) -> None:
check_shared_mac(node,topology)
if 'dhcp' in mods:
check_dhcp_clients(node,topology)
if 'lag' in mods:
check_l3_lag(node,topology)
if 'ospf' in mods:
passive_stub_interfaces(node,topology)
if 'eos' in node:
Expand Down

0 comments on commit bc79d3e

Please sign in to comment.