STP: Add stp.port_type configuration for Cumulus 4.x/NVUE, EOS and Dell OS10 #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jbemmel
commented
Dec 6, 2024
•
jbemmel
commented
- Option to auto-configure stp.port_type as 'edge' for ports with only hosts connected, default disabled
- Feature flag stp.port_type (not supported by FRR)
|
Would it be too hard to finish your work before opening a pull request? Nobody is interested in notifications about your interim fixes. |
Sorry, will try to do better - I get ahead of myself sometimes |
ipspace
requested changes
Dec 8, 2024
jbemmel
force-pushed
the
stp-port-type
branch
from
86180ec to
3bcc2ae
Compare
ipspace
requested changes
Dec 9, 2024
jbemmel
force-pushed
the
stp-port-type
branch
from
e6c9ae7 to
c6b71d5
Compare
* Option to configure host-facing ports as 'edge', default enabled * Feature flag to indicate support (FRR does not support specific configuration for port_type)
…ction on EOS * Renamed ```host_edge_port``` to ```stub_port_type``` (default "edge"), also allow "none" to disable setting * Updated documentation
* Manually copy node level stp.port_type to interfaces that support STP (only) * VLAN attribute not being picked up yet
jbemmel
force-pushed
the
stp-port-type
branch
from
7d02f57 to
1e13a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.