-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: add lag support and bonding plugin for non-lag cases #1624
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor details plus a major problem: we don't get the Linux static routes for the lab pools (they are supposed to point to the first data-plane interface), so the Linux host cannot reach anything but the adjacent router.
Fix the nits and I'll add the static routes part.
Also, just wondering: how does netplan-based Ubuntu configuration work with handcrafted bond devices? |
It shows them as "unmanaged" just like the 'lo' device (odd to see that), but I agree it would be nicer to craft netplan configs where available. Will adjust |
33e1ee4
to
d20c7ef
Compare
Static route issue is tracked in #1641. I will probably go for a simple fix in the configuration template (that code is ancient) |
…the device bond1 instead of eth1 IP allocation doesn't work the same - possibly some dependency on link.type
( this is an example why Ivan doesn't like link.type=='lag'... )
…comes stub). Some cleanup remains required
Moved to a new 'bonding' plugin as it is not link aggregation
Supports the Linux bonding modes that work with autonomous ports
a884b6f
to
1cb4cea
Compare
Update test results
Works on Libvirt, bonding mode on clab becomes round-rr for some reason
Ready to add the static route bits |
lag
module and for thebonding
pluginIn all cases, bonding devices are created in
initial
such that any IP addresses can be assigned. Bond/lag members are then added in the respectivelag
module andbonding
plugin