Various tweaks to numeric optimizations found while looking at programs. #18765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stellaraccident
commented
Oct 12, 2024
•
stellaraccident
commented
- Expands affine.apply ops at the program level. These get introduced from various places that should possibly be eliminated at this level. For now expanding them gets the job done, making the program transformation friendly again.
- Fixes a multi-use issue in i64->index promotion.
- Adds a pattern to fold trunc of an index cast.
- Uses a conservative limit to bound all dynamic dims at the torch level, even when coming to us as unbounded.
- Implements analysis interfaces on util.align.
benvanik
approved these changes
Oct 12, 2024
|
|
stellaraccident
force-pushed
the
users/stella/numeric_opt_hitlist
branch
from
85ff8a8 to
af37991
Compare
* Expands affine.apply ops at the program level. These get introduced from various places that should possibly be eliminated at this level. For now expanding them gets the job done, making the program transformation friendly again. * Fixes a multi-use issue in i64->index promotion. * Adds a pattern to fold trunc of an index cast. * Uses a conservative limit to bound all dynamic dims at the torch level, even when coming to us as unbounded. Signed-off-by: Stella Laurenzo <[email protected]>
stellaraccident
force-pushed
the
users/stella/numeric_opt_hitlist
branch
from
12905cb to
7aa185e
Compare
Signed-off-by: Stella Laurenzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.