[GPU] Use affine.delinearize_index for MMA tiles and vector distribution #19228
+526
−333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates some by-hand delinearizations in MMA tile generation and vector distribution to use
affine.delinearize_index
instead.The main tricky thing here is that a lot of that MMA code would use
(id / stride) % size
, whereas delinearize's outputs all have the form(id % stride) / nextStride
. In all the cases at issue, we could use a utility to convert arrays of sizes and strides to a permutation on a delinearization basis.In order to not break existing tests, the trivial-loop detector had to be manually instrumented to support
delinearize_index
(and I gotutil.assume.int
while I was there). (I suspect there're a few other cases, and that, long-term, that detector should be using one of the bounds interfaces, but that's not this PR)