[GPU] Add pattern to fuse tensor.extract_slice into forall producer #19296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max191
force-pushed
the
extract-slice-forall-fusion
branch
2 times, most recently
from
2f5056e to
8f9be22
Compare
|
This is based on #19295. Please only review the last commit. Edit: rebased now. |
Max191
force-pushed
the
extract-slice-forall-fusion
branch
from
8f9be22 to
f46540f
Compare
Max191
force-pushed
the
extract-slice-forall-fusion
branch
from
f46540f to
72b7b62
Compare
Max191
force-pushed
the
extract-slice-forall-fusion
branch
2 times, most recently
from
37f21ba to
1885572
Compare
Max191
force-pushed
the
extract-slice-forall-fusion
branch
from
1885572 to
105d13a
Compare
|
@qedawkins gentle ping. I rebased this PR now that #19295 has been merged, and it is ready for review. |
Max191
force-pushed
the
extract-slice-forall-fusion
branch
from
105d13a to
20d988c
Compare
qedawkins
approved these changes
Jan 27, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/TransformExtensions/IREEGPUExtensionsOps.td
Outdated
Show resolved
Hide resolved
...r/Codegen/Dialect/GPU/TransformExtensions/test/transform_fuse_extract_slice_with_forall.mlir
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/Transforms.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/Transforms.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/Transforms.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Max Dawkins <[email protected]>
Signed-off-by: Max Dawkins <[email protected]>
Max191
force-pushed
the
extract-slice-forall-fusion
branch
from
20d988c to
66c2381
Compare
ita9naiwa
pushed a commit
to ita9naiwa/iree
that referenced
this pull request
Feb 4, 2025
…ree-org#19296) This PR adds a pattern to fuse a consumer tensor.extract_slice into a producer scf.forall op. The transform is added to FuseAndHoistParallelLoops, where it helps to fuse tensor.unpack ops with extract_slice semantics into producer loops. This is needed when targeting MFMA intrinsics for unaligned shapes, and also in generating code for unset encoding ops on GPU. This is a follow up to iree-org#19295, which has the complementing pattern for collapse_shape. The PR also adds a transform op to keep the long lit tests separate from the FuseAndHoistParallelLoop tests. --------- Signed-off-by: Max Dawkins <[email protected]> Signed-off-by: Max Dawkins <[email protected]> Co-authored-by: Max Dawkins <[email protected]> Signed-off-by: Hyunsung Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pattern to fuse a consumer tensor.extract_slice into a producer scf.forall op. The transform is added to FuseAndHoistParallelLoops, where it helps to fuse tensor.unpack ops with extract_slice semantics into producer loops. This is needed when targeting MFMA intrinsics for unaligned shapes, and also in generating code for unset encoding ops on GPU. This is a follow up to #19295, which has the complementing pattern for collapse_shape.
The PR also adds a transform op to keep the long lit tests separate from the FuseAndHoistParallelLoop tests.