Adding experimental iree_io_file_map_view API. #19515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
force-pushed
the
users/benvanik/host-file-3
branch
from
2121abe to
580febb
Compare
benvanik
force-pushed
the
users/benvanik/host-file-4
branch
from
ef1ef57 to
1714860
Compare
AWoloszyn
reviewed
Dec 18, 2024
benvanik
force-pushed
the
users/benvanik/host-file-3
branch
from
580febb to
76b85b0
Compare
AWoloszyn
approved these changes
Dec 18, 2024
This allows for any iree_io_file_handle_t to be mapped into host memory on platforms where doing so is supported. Eventually this will be replaced with a proper mapping object and view API that will allow us to unify the ELF loading, file_io utils, and parameter handling APIs.
benvanik
force-pushed
the
users/benvanik/host-file-4
branch
from
1714860 to
81efe25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for any iree_io_file_handle_t to be mapped into host memory on platforms where doing so is supported. Eventually this will be replaced with a proper mapping object and view API that will allow us to unify the ELF loading, file_io utils, and parameter handling APIs.