[FLOW] Move InitializeEmptyTensors before CaptureDynamicDims #19563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zjgarvey <[email protected]>
zjgarvey
requested review from
hanhanW,
MaheshRavishankar and
IanWood1
as code owners
|
If someone could help me figure out what kind of test would be appropriate for this, I would appreciate it. |
|
It looks like were missing tests for |
MaheshRavishankar
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some patterns take in a
tensor.emptyop as theiter_argforscf.forops, but these ops don't get handled when capturing dynamic dims. Moving the conversion oftensor.emptytoflow.tensor.emptybeforeCaptureDynamicDimsallows these dynamic dims to properly propagate through the loop.