[Dispach] Clone chain of ops into dispatch #19723
Merged
+66
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanhanW
approved these changes
Jan 17, 2025
This change modifies `cloneProducersToRegion` to iteratively clone producers into the region. For example if ther is a chain A -> B -> Dispatch, where A and B are cloneable. `A` is only detected as a clonable op after `B` has been cloned. Signed-off-by: Ian Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies
cloneProducersToRegionto iteratively clone producers into the region. For example if ther is a chain A -> B -> Dispatch, where A and B are cloneable.Ais only detected as a clonable op afterBhas been cloned.Also traverses backwards to delete trivially dead ops so that consumers get erased first.