Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource placement and transfer for barrier operations #19725

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

rsuderman
Copy link
Contributor

Barriers indicate within device blocking. The results of a barrier should not transfer to another location, otherwise there would be a transfer and not a barrier.

Barriers indicate within device blocking. The results of a barrier
should not transfer to another location, otherwise there would be a
transfer and not a barrier.
@rsuderman rsuderman requested a review from benvanik as a code owner January 17, 2025 00:36
Copy link
Collaborator

@benvanik benvanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding a test above util.func public @tensorTransfer in Stream/Conversion/FlowToStream/test/tensor_ops.mlir for this?

@rsuderman rsuderman requested a review from benvanik January 17, 2025 02:22
@rsuderman rsuderman merged commit f31cc72 into iree-org:main Jan 17, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants