Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Util] Fix OptimizeIntArithmetic pattern failure condition #19731

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[Util] Fix OptimizeIntArithmetic pattern failure condition #19731

merged 1 commit into from
Jan 17, 2025

Conversation

Groverkss
Copy link
Contributor

The condition is wrong and leads to infinite loops if the input is i32 and output is index type.

@Groverkss Groverkss requested a review from benvanik as a code owner January 17, 2025 17:51
@Groverkss Groverkss requested a review from krzysz00 January 17, 2025 17:52
benvanik
benvanik approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@benvanik benvanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@Groverkss Groverkss merged commit c5bc37f into iree-org:main Jan 17, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benvanik benvanik benvanik approved these changes

@krzysz00 krzysz00 Awaiting requested review from krzysz00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Groverkss @benvanik