adding github actions for linting and testing #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patnir
changed the title
patnir
commented
Feb 29, 2024
andiflabs
requested changes
Mar 1, 2024
ci/lintHeaders.sh
Outdated
| license2=" * License, v. 2.0. If a copy of the MPL was not distributed with this" | ||
| license3=" * file, You can obtain one at https://mozilla.org/MPL/2.0/. */" | ||
|
|
||
| files=$(find $1 -type f -name '*.rs') |
There was a problem hiding this comment.
Use an array to avoid unwanted expansion later on:
files=( src/**/*.rs )or:
files=( **/*.rs )
ci/lintHeaders.sh
Outdated
| 2 | ||
| 3' | ||
|
|
||
| for file in $files; do |
There was a problem hiding this comment.
If you make files an array, then replace $files with "${files[@]}" to prevent expansion
Comment on lines
+14
to
+20
| headerLineNumbers() { | ||
| grep -Fn -e "$license1" -e "$license2" -e "$license3" "$1" | cut -f1 -d: | ||
| } | ||
|
|
||
| expectedHeaderLineNumbers='1 | ||
| 2 | ||
| 3' |
There was a problem hiding this comment.
I guess this works but perhaps an easier way to achieve the same result would be:
license="/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */"
[[ "$(head -n3 "$1")" = "$license" ]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting + Testing CI Github Action