defines round1 Package struct #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
reviewed
Apr 9, 2024
wraps frost-core round1 Package and includes identity, group_secret_key_part, and checksum - the identity is the identity of the participant who generated the package. - the group_secret_key_part is a 32 byte Sapling key that will be combined with group_secret_key_parts from other participants to generate the group_secret_key (used to derive nsk and ovk). - the checksum is computed from the list of signer identities and min_signers that were used in round1.
helps to ensure that we use the same hasher for checksum implementations
removes FrostPackage alias for Package type from frost-core
updates to take slice of references to Identities instead of slice of structs
hughy
force-pushed
the
feat/hughy/round1-package-struct
branch
from
9df9400 to
9a3b041
Compare
uses our PublicPackage struct instead of the Package struct from frost-core
hughy
force-pushed
the
feat/hughy/round1-package-struct
branch
from
9a3b041 to
b57afbc
Compare
andiflabs
reviewed
Apr 10, 2024
andiflabs
reviewed
Apr 10, 2024
andiflabs
approved these changes
Apr 10, 2024
uses GroupSecretKeyShared struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wraps frost-core round1 Package and includes identity, group_secret_key_part, and checksum