Add functionality to serialize/deserialize/import/export the round2 SecretPackages #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
force-pushed
the
andrea/dkg-round2-secret-package-serde
branch
from
44806f8 to
297fa82
Compare
rohanjadvani
approved these changes
Apr 10, 2024
hughy
reviewed
Apr 10, 2024
| reader.read_exact(&mut scalar)?; | ||
| let scalar: Option<Scalar> = Scalar::from_bytes(&scalar).into(); | ||
| let secret_share = | ||
| scalar.ok_or_else(|| io::Error::other("coefficients deserialization failed"))?; |
There was a problem hiding this comment.
nit - error message references coefficients instead of secret share
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to fc199fd and b6537a9, but for round2 instead of round1.