-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frost): Add round 2 package struct #51
Merged
rohanjadvani
merged 9 commits into
main
from
rohan/ifl-2460-add-serialization-for-frost-round-two-package
Apr 11, 2024
Merged
feat(frost): Add round 2 package struct #51
rohanjadvani
merged 9 commits into
main
from
rohan/ifl-2460-add-serialization-for-frost-round-two-package
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
approved these changes
Apr 11, 2024
src/dkg/round1.rs
Outdated
@@ -239,6 +240,20 @@ impl PublicPackage { | |||
} | |||
} | |||
|
|||
impl Ord for PublicPackage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreacorbellini mentioned here that we can use sort_unstable_by_key
for sorting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
hughy
approved these changes
Apr 11, 2024
rohanjadvani
deleted the
rohan/ifl-2460-add-serialization-for-frost-round-two-package
branch
April 11, 2024 18:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.