no-std ironfish-frost compatibility #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfish-frost into no-std-multiencode
jowparks
force-pushed
the
upgrade-reddsa
branch
4 times, most recently
from
f2ee8c6 to
0b4c2b0
Compare
NullSoldier
reviewed
Jul 30, 2024
| let max_signers = u16::try_from(participants.len()) | ||
| .map_err(|_| Error::InvalidInput("too many participants".to_string()))?; | ||
| let max_signers = | ||
| u16::try_from(participants.len()).map_err(|_| IronfishFrostError::InvalidInput)?; |
There was a problem hiding this comment.
Seems like we lost information with just using a generic InvalidInput error.
There was a problem hiding this comment.
Yea we did, but if we don't remove it we will have to encode these strings in the binary.
jowparks
force-pushed
the
upgrade-reddsa
branch
3 times, most recently
from
442cb7f to
cd27561
Compare
jowparks
force-pushed
the
upgrade-reddsa
branch
2 times, most recently
from
9a8d28f to
b590a9c
Compare
jowparks
commented
Aug 7, 2024
Cargo.toml
Outdated
| reddsa = { git = "https://github.com/ZcashFoundation/reddsa.git", rev = "311baf8865f6e21527d1f20750d8f2cf5c9e531a", features = ["frost", "frost-rerandomized"] } | ||
| siphasher = { version = "1.0.0", optional = true } | ||
| reddsa = { git = "https://github.com/ZcashFoundation/reddsa.git", rev = "b9c3107e6ec5333a89a7fa064f2d10f749a90cce", features = ["frost", "frost-rerandomized"] } | ||
| siphasher = { version = "1.0.0", features =["serde_no_std"] } |
There was a problem hiding this comment.
Allows siphasher to be used with both std and no-std
jowparks
force-pushed
the
upgrade-reddsa
branch
from
b590a9c to
9a8d28f
Compare
jowparks
changed the title
jowparks
force-pushed
the
no-std
branch
5 times, most recently
from
93a6030 to
ddfbe11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some serialization changes in
frost=2.0.0-rc. We also had three separate error types that were being difficult to reconcile, consolidated them.