removes signature from SigningCommitment #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
our SigningCommitment type includes a signature of the identity of the participant creating the commitment, the raw signing commitments, and the input checksum the signature allows other participants to verify that the commitment was created by the participant whose identity is included in the SigningCommitment. this verification takes place before creating a SigningPackage. without this verification an invalid SigningPackage can be created: the participant identity with the mismatched signing commitment will be unable to generate a signature share. the signature therefore allows the signing process to terminate one step earlier in case a participant generates an invalid commitment. the multisig Ledger app will not be able to generate this signature without additional features. these changes remove the signature from the SigningCommitment struct so that we will be able to create SigningCommitment instances from raw commitments generated on Ledger devices.
mat-if
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our SigningCommitment type includes a signature of the identity of the participant creating the commitment, the raw signing commitments, and the input checksum
the signature allows other participants to verify that the commitment was created by the participant whose identity is included in the SigningCommitment. this verification takes place before creating a SigningPackage. without this verification an invalid SigningPackage can be created: the participant identity with the mismatched signing commitment will be unable to generate a signature share. the signature therefore allows the signing process to terminate one step earlier in case a participant generates an invalid commitment.
the multisig Ledger app will not be able to generate this signature without additional features.
these changes remove the signature from the SigningCommitment struct so that we will be able to create SigningCommitment instances from raw commitments generated on Ledger devices.