Fix exporter for different NUMA nodes #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlagueCZ
force-pushed
the
fix/exporter_numa
branch
from
a7ce790
to
84cdfeb
Compare
PlagueCZ
force-pushed
the
fix/exporter_numa
branch
from
84cdfeb
to
6a7eea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dpservice-exporter uses
/eal/heap_info,0on all nodes. Some nodes in OSC require the use of/eal/heap_info,1, so this PR uses/eal/heap_listto ask for the right (NUMA node?) number.I am not that versed in Go, so I simply "copied" the code for interfaces, therefore this code would not work when there are multiple
heap_infoentries. But for our deployment it should be fine.Connected to #606