Increase normal packet mempool member size #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this was a hotfix from yesterday that I already discussed with @guvenc as it breaks operation on SAP side. I would think that the bigger PR takes more time to approve, so it's also separate here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix for the previous change to mempool sizes. I forgot about adding the IPv6 tunnel header because OSC uses MTU 1400 in its VMs.
I wanted to add a pytest for some maximum MTU, however (with tap devices at least) DPDK stops being able to push the packet to an interface sooner than the memory limit is reached.
This does however fix a problem using Mellanox with VMs having 1500 MTU, I have tested in my local setup.