Acquire neighboring router MAC dynamically #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XXL
documentation
PlagueCZ
force-pushed
the
feature/dynamic_neighmac
branch
5 times, most recently
from
cbb2a2c
to
2d35767
Compare
PlagueCZ
force-pushed
the
feature/dynamic_neighmac
branch
from
2d35767
to
722a29d
Compare
|
Closing due to pending commits from previous PR (something I do not remember working like this in the past) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dpservice acquires neighboring router MAC addresses during initialization.
Not only this is a problem if there is a port replaced on a switch (thus the MAC changes), but in multiport-eswitch with pf1-proxy, the MAC is taken from the proxy port. But without dpservice running, there are no neigbors registered (because the proxy interface is effectively dead at that time), so the MAC needs to be loaded dynamically after a while.
Thus I added a mechanism that in case of a missing neighboring router MAC, a timer is started and the retrieval is retried again later.
The timer has an exponential backoff, starting with 1s and doubled each time, until it reaches 60s.
This PR is best read commit-by commit, since that shows the evolution of all the changes.
Connected to #606
There was also a need for the init container to fail when some of the values for
dp_service.confwere not available. I lumped it together here as there were already changes to the prepare script, but this can be separated if needed.