Do not delete conntrack reply direction keys #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byteocean
reviewed
Nov 5, 2024
guvenc
force-pushed
the
fix/snat_crash
branch
from
46f93ea
to
9a11050
Compare
Do not delete conntrack reply direction keys to satisfy the assumption that conntrack entries have two references. Signed-off-by: Guvenc Gulce <[email protected]>
guvenc
force-pushed
the
fix/snat_crash
branch
from
9a11050
to
d2f5b2c
Compare
guvenc
force-pushed
the
fix/snat_crash
branch
2 times, most recently
from
f14bc09
to
d2f5b2c
Compare
byteocean
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not delete conntrack reply direction key to satisfy the assumption that conntrack entries have two references.
Instead drop the reply direction of the neighbour NAT and LB forward packets early in conntrack node as these packets are
not supposed to be received,
Fix attempt for #621