Fix linting issues by excluding tests and fake server

.golangci.yml

@@ -48,6 +48,12 @@ linters-settings:
         alias: ${1}client
 
 issues:
+  # exclude copylocks issues in fake servers and unit tests
+  exclude-files:
+    - iri/testing/volume/fake.go
+    - iri/testing/bucket/fake.go
+    - iri/testing/machine/fake.go
+    - poollet/machinepoollet/controllers/machine_controller_test.go
   # don't skip warning about doc comments
   # don't exclude the default set of lint
   exclude-use-default: false

broker/machinebroker/cmd/machinebroker/app/app.go

@@ -122,7 +122,7 @@ func Run(ctx context.Context, opts Options) error {
 
 	g, ctx := errgroup.WithContext(ctx)
 	g.Go(func() error {
-		return runServer(ctx, setupLog, log, srv)
+		return runServer(ctx, setupLog, srv)
 	})
 	g.Go(func() error {
 		return runGRPCServer(ctx, setupLog, log, srv, opts)
@@ -133,7 +133,7 @@ func Run(ctx context.Context, opts Options) error {
 	return g.Wait()
 }
 
-func runServer(ctx context.Context, setupLog, _ logr.Logger, srv *server.Server) error {
+func runServer(ctx context.Context, setupLog logr.Logger, srv *server.Server) error {
 	setupLog.V(1).Info("Starting server loops")
 	if err := srv.Start(ctx); err != nil {
 		return fmt.Errorf("error starting server loops: %w", err)

hack/tools.go

@@ -9,7 +9,5 @@
 package hack
 
 import (
-	// Use gogoproto for protobuf generation.
-	_ "github.com/gogo/protobuf/gogoproto"
 	_ "k8s.io/code-generator"
 )