Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get events command to irictl-machine #1089

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Add get events command to irictl-machine #1089

merged 3 commits into from
Jul 16, 2024

Conversation

ushabelgur
Copy link
Contributor

@ushabelgur ushabelgur commented Jul 15, 2024 •
edited by lukasfrank
Loading

Proposed Changes

  • Refactor event structure
  • Refactor list event method in broker to fetch all events by kind Machine and API version
  • Add get events command to irictl-machine

@github-actions github-actions bot added bug Something isn't working size/XXL labels Jul 15, 2024
@ushabelgur ushabelgur marked this pull request as ready for review July 15, 2024 14:30
@ushabelgur ushabelgur requested a review from a team as a code owner July 15, 2024 14:30
@afritzler afritzler changed the title Refactor IRI list events method for machine and add get events command to irictl-machine Add getevents command to irictl-machine Jul 16, 2024
@afritzler afritzler changed the title Add getevents command to irictl-machine Add get events command to irictl-machine Jul 16, 2024
@afritzler
Copy link
Member

Can we rename the command to list events instead of using get events?

lukasfrank
lukasfrank requested changes Jul 16, 2024
View reviewed changes
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
broker/machinebroker/server/event_list.go Show resolved Hide resolved
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
irictl-machine/cmd/irictl-machine/irictlmachine/get/get.go Outdated Show resolved Hide resolved
iri/apis/machine/v1alpha1/api.proto Outdated Show resolved Hide resolved
lukasfrank
lukasfrank reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@lukasfrank lukasfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .reuse/dep5 iri/apis/event can be added to fix the failure of the pipeline:

https://github.com/ironcore-dev/ironcore/actions/runs/9955097009/job/27502122368

lukasfrank
lukasfrank approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@lukasfrank lukasfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great contribution!

@lukasfrank lukasfrank added the enhancement New feature or request label Jul 16, 2024
@lukasfrank lukasfrank merged commit e9e9584 into main Jul 16, 2024
21 checks passed
@lukasfrank lukasfrank deleted the fix/iri_machine_events branch July 16, 2024 15:27
@lukasfrank lukasfrank removed the bug Something isn't working label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ushabelgur @afritzler @lukasfrank