Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade K8s Dependencies to v0.30.4 #1112

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Upgrade K8s Dependencies to v0.30.4 #1112

merged 8 commits into from
Oct 28, 2024

Conversation

sujeet01
Copy link
Contributor

@sujeet01 sujeet01 commented Sep 4, 2024

This PR upgrades our Kubernetes package dependencies from v0.29.4 to v0.30.4 and implements necessary code refactoring to accommodate breaking changes.

Proposed Changes:

  • Upgrade K8s Dependencies: Bumped k8s.io/* dependencies from v0.29.4 to v0.30.4 to incorporate the latest features and improvements. Fixes Bump k8s.io/* deps to v0.30 #1113
  • Upgrade Controller-Runtime: Bumped sigs.k8s.io/controller-runtime from v0.17.3 to v0.18.5 to ensure compatibility with the upgraded k8s dependencies.
  • Refactor for Breaking Changes: Adjusted code to address breaking changes introduced in the new version.
  • Update Code Generation Script: Adapted hack/update-codegen.sh script to utilize the kube_codegen.sh script functions, aligning with updated k8s code generation standards.
  • Update OpenAPI-Gen Package: The openapi-gen has been removed from k8s.io/code-generator by PR #123529 because it is redundant with the version in k8s.io/kube-openapi.
  • Update Makefile: Updated ENVTEST_K8S_VERSION from 1.28.0 to 1.30.3 and performed cleanup by removing obsolete generation tool binaries.
  • Run Make Generate: Executed make generate to apply all code generation tasks with the updated setup.
  • Update Import Paths: Updated import paths to match the new locations of the generated client code.

Fixes #1094

@github-actions github-actions bot added size/XL enhancement New feature or request labels Sep 4, 2024
@sujeet01 sujeet01 self-assigned this Sep 4, 2024
@sujeet01 sujeet01 changed the title Upgrade K8s Dependencies to v0.30.4 and Refactor Code for Breaking Changes Upgrade K8s Dependencies to v0.30.4 Sep 4, 2024
@sujeet01 sujeet01 force-pushed the enh/upgrade-k8s-v0.30.4 branch 16 times, most recently from 6a437b9 to d045021 Compare September 5, 2024 13:47
@sujeet01 sujeet01 marked this pull request as ready for review September 6, 2024 08:02
@sujeet01 sujeet01 requested a review from a team as a code owner September 6, 2024 08:02
@sujeet01 sujeet01 force-pushed the enh/upgrade-k8s-v0.30.4 branch 2 times, most recently from a38d7e8 to 15cef12 Compare September 10, 2024 15:32
@sujeet01 sujeet01 force-pushed the enh/upgrade-k8s-v0.30.4 branch 4 times, most recently from 07fde92 to 7311629 Compare October 22, 2024 16:49
internal/quota/evaluator/ironcore/onmetal.go Show resolved Hide resolved
.github/workflows/check-codegen.yml Outdated Show resolved Hide resolved
@sujeet01 sujeet01 force-pushed the enh/upgrade-k8s-v0.30.4 branch 4 times, most recently from 82e3ac4 to da06ccf Compare October 24, 2024 08:59
@afritzler
Copy link
Member

For me make generate fails on an clean project with:

./hack/update-codegen.sh: line 12: /kube_codegen.sh: No such file or directory

I would suggest to modify the hack script to fetch it from the correct location in the go mod cache.

@sujeet01
Copy link
Contributor Author

For me make generate fails on an clean project with:

./hack/update-codegen.sh: line 12: /kube_codegen.sh: No such file or directory

I would suggest to modify the hack script to fetch it from the correct location in the go mod cache.

Thanks for catching this issue. I have addressed this in the latest commit by reordering the steps in the hack script to download dependencies before setting CODE_GEN_DIR. This should resolve the problem, and make generate should now work as expected on a clean project.

@afritzler afritzler merged commit 0a97419 into main Oct 28, 2024
9 checks passed
@afritzler afritzler deleted the enh/upgrade-k8s-v0.30.4 branch October 28, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump k8s.io/* deps to v0.30 Bump k8s.io/* deps to v0.30
2 participants