Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VolumeRef to Machine status #1125

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Added VolumeRef to Machine status #1125

merged 4 commits into from
Oct 7, 2024

Conversation

ushabelgur
Copy link
Contributor

@ushabelgur ushabelgur commented Sep 23, 2024 •
edited by Rohit-0505
Loading

Proposed Changes

  • Add VolumeRef of type corev1.LocalObjectReference toMachine.Status.VolumeStatus struc for identifying the claimed Volume
  • Update logic to set claimed VolumeRef in machinepoollet
  • Add test cases to cover ephemeral volume
  • Fix sporadic test failure in core_test.go

Fixes #1118

@github-actions github-actions bot added size/L enhancement New feature or request labels Sep 23, 2024
@ushabelgur ushabelgur marked this pull request as ready for review September 23, 2024 09:12
@ushabelgur ushabelgur requested a review from a team as a code owner September 23, 2024 09:12
@ushabelgur ushabelgur self-assigned this Sep 24, 2024
@ushabelgur ushabelgur force-pushed the enh/machine_status_volume_claim_ref branch from 7c15950 to a1adbee Compare September 24, 2024 05:41
@lukasfrank lukasfrank changed the title Enhance Machine status to track a reference for its claimed Volume resource Added VolumeRef to Machine status Sep 30, 2024
@balpert89
Copy link
Contributor

LGTM

@Rohit-0505 Rohit-0505 force-pushed the enh/machine_status_volume_claim_ref branch from 85bfe99 to 75c0170 Compare October 3, 2024 06:43
@Rohit-0505 Rohit-0505 force-pushed the enh/machine_status_volume_claim_ref branch from 75c0170 to 54db239 Compare October 3, 2024 07:01
@Rohit-0505 Rohit-0505 force-pushed the enh/machine_status_volume_claim_ref branch from 1991357 to 2c316ba Compare October 3, 2024 09:06
@lukasfrank lukasfrank merged commit 8167537 into main Oct 7, 2024
10 checks passed
@lukasfrank lukasfrank deleted the enh/machine_status_volume_claim_ref branch October 7, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

@balpert89 balpert89 Awaiting requested review from balpert89

Assignees

@ushabelgur ushabelgur

Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Machine status should track a reference for its claimed Volume resource
4 participants
@ushabelgur @balpert89 @lukasfrank @Rohit-0505