Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e example for Machine creation using non ephemeral resources #1133

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Add e2e example for Machine creation using non ephemeral resources #1133

merged 5 commits into from
Oct 21, 2024

Conversation

Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Oct 10, 2024 •
edited
Loading

Proposed Changes

  • Add manifests for machine creation and expose it to internet via virtualIP
  • Add ignition.yaml to create the ignition secret

Fixes #1129(partially)

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner October 10, 2024 09:09
@github-actions github-actions bot added size/L documentation Improvements or additions to documentation enhancement New feature or request labels Oct 10, 2024
@Rohit-0505 Rohit-0505 self-assigned this Oct 10, 2024
@Rohit-0505 Rohit-0505 force-pushed the enh/e2e-test-manifests branch 3 times, most recently from 9e070fb to 98bd5b7 Compare October 11, 2024 06:48
afritzler
afritzler requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the examples into a bases folder under samples/e2e and leave the patch samples out of his all together as they have to be defined by the consumer.

@Rohit-0505
Copy link
Contributor Author

Can we move the examples into a bases folder under samples/e2e and leave the patch samples out of his all together as they have to be defined by the consumer.

done

@Rohit-0505 Rohit-0505 mentioned this pull request Oct 16, 2024
Open
@afritzler afritzler changed the title Add manifests to create a machine, install nginx and expose it via virtualIP Add e2e example for Machine creation using non ephemeral resources Oct 21, 2024
@afritzler afritzler merged commit 8ea3843 into main Oct 21, 2024
15 checks passed
@afritzler afritzler deleted the enh/e2e-test-manifests branch October 21, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@Rohit-0505 Rohit-0505

Labels
documentation Improvements or additions to documentation enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2e examples
2 participants
@Rohit-0505 @afritzler