Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use process substitution in hack/update-codegen.sh #1146

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Do not use process substitution in hack/update-codegen.sh #1146

merged 2 commits into from
Oct 30, 2024

Conversation

lukasfrank
Copy link
Member

Proposed Changes

  • Fix codegen on macOS without GNU bash

@github-actions github-actions bot added bug Something isn't working size/XS labels Oct 29, 2024
afritzler
afritzler requested changes Oct 29, 2024
View reviewed changes
hack/update-codegen.sh Show resolved Hide resolved
@afritzler afritzler added enhancement New feature or request and removed bug Something isn't working labels Oct 29, 2024
@afritzler
Copy link
Member

I would categorize it as a feature :)

@afritzler afritzler changed the title Fix process substitution without GNU bash Do not use process substitution in hack/update-codegen.sh Oct 29, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 29, 2024
@lukasfrank lukasfrank removed the bug Something isn't working label Oct 29, 2024
@lukasfrank lukasfrank marked this pull request as ready for review October 29, 2024 13:23
@lukasfrank lukasfrank requested a review from a team as a code owner October 29, 2024 13:23
@lukasfrank lukasfrank merged commit 2944118 into main Oct 30, 2024
9 checks passed
@lukasfrank lukasfrank deleted the fix/codegen branch October 30, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasfrank @afritzler