Add flags for QPS and Burst to *-poollet and *-broker
#1157
+192
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas016
force-pushed
the
osc/fix/client-rate-settings
branch
from
a04175c
to
7833274
Compare
|
removed the no-op rate limiting configuration. |
afritzler
requested changes
Nov 25, 2024
afritzler
added
enhancement
afritzler
changed the title
QPS and Burst to *-poollet and *-broker
lukas016
force-pushed
the
osc/fix/client-rate-settings
branch
from
2a6c8a5
to
c85ebab
Compare
lukas016
force-pushed
the
osc/fix/client-rate-settings
branch
from
c85ebab
to
afcae77
Compare
lukasfrank
requested changes
Nov 26, 2024
balpert89
force-pushed
the
osc/fix/client-rate-settings
branch
from
8895d51
to
c47a97e
Compare
afritzler
requested changes
Nov 27, 2024
…ptionsUpdated `Options` struct with `QPS` and `Burst` fields, added corresponding flags in `AddFlags` method, and set these values in the `Run` function for ippoollet, machinepoollet, and volumepoollet controllers. This allows configurable rate limits for Kubernetes client requests and logs the settings on startup.Suggestion: Review the changes to ensure consistency and test the new configuration options. Signed-off-by: Benjamin Alpert <[email protected]> change poollet client specific qps and burst opts implementation to common options pattern change to client config defaults for qps and burst
lukas016
force-pushed
the
osc/fix/client-rate-settings
branch
from
c47a97e
to
a203ee6
Compare
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.35.1 to 1.36.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.35.1...v1.36.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…e-dev#1174) Bumps [github.com/bits-and-blooms/bitset](https://github.com/bits-and-blooms/bitset) from 1.15.0 to 1.17.0. - [Release notes](https://github.com/bits-and-blooms/bitset/releases) - [Commits](bits-and-blooms/bitset@v1.15.0...v1.17.0) --- updated-dependencies: - dependency-name: github.com/bits-and-blooms/bitset dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
afritzler
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
QPSandBurstfor broker and poollet componentsQPSandBurstclient configuration configurableconcurrent max reconcilesconfigurableFixes #1154