Add requeueAfter to volume deletion flow
#1158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
requested changes
Nov 22, 2024
| @@ -125,7 +127,7 @@ func (r *VolumeReconciler) deleteGone(ctx context.Context, log logr.Logger, volu | |||
| } | |||
| if !ok { | |||
| log.V(1).Info("Not all iri volumes are gone, requeueing") | |||
| return ctrl.Result{Requeue: true}, nil | |||
| return ctrl.Result{Requeue: true, RequeueAfter: 5 * time.Second}, nil | |||
There was a problem hiding this comment.
Can we make this configurable via a flag?
There was a problem hiding this comment.
Also
// RequeueAfter if greater than 0, tells the Controller to requeue the reconcile key after the Duration.
// Implies that Requeue is true, there is no need to set Requeue to true at the same time as RequeueAfter.
RequeueAfter time.Duration
afritzler
added
enhancement
afritzler
changed the title
requeueAfter to volume deletion flow
lukasfrank
reviewed
Nov 22, 2024
| @@ -198,7 +200,7 @@ func (r *VolumeReconciler) delete(ctx context.Context, log logr.Logger, volume * | |||
| } | |||
| if !ok { | |||
| log.V(1).Info("Not all iri volumes are gone, requeueing") | |||
| return ctrl.Result{Requeue: true}, nil | |||
| return ctrl.Result{Requeue: true, RequeueAfter: 5 * time.Second}, nil | |||
There was a problem hiding this comment.
tbh. I'm not sure if we should use a "fixed" delay, since we are working actively against the controller-runtime requeue mechanism with an exponential backoff. Waiting a fixed time multiplies if we build multiple layers of the brokers/poollets. Wdyt about returning an error to circumvent this?
There was a problem hiding this comment.
I think even without returning an error we already have the optimal behavior: https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/reconcile/reconcile.go#L99-L112
There was a problem hiding this comment.
// If the error is nil and result.RequeueAfter is zero and result.Requeue is true, the request
// will be requeued using exponential backoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #1155