Fix IRI *-broker status
#1169
Merged
Fix IRI *-broker status
#1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas016
force-pushed
the
osc/fix-broker-status-response-single-pool
branch
from
4141661
to
1552a54
Compare
|
LGTM |
lukasfrank
requested changes
Nov 22, 2024
lukasfrank
changed the title
*-broker status
lukas016
force-pushed
the
osc/fix-broker-status-response-single-pool
branch
from
4336c9d
to
66ec926
Compare
lukasfrank
approved these changes
Nov 22, 2024
afritzler
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR addresses an issue in the getTargetIronCoreMachinePools method within the broker status IRI response. Currently, the method retrieves and returns a list of all MachinePools in the cluster, even when a specific MachinePool is provided. This behavior occurs due to a missing return statement when a single MachinePool is fetched.