Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide resource visibility if user is not in defined group #856

Closed
wants to merge 3 commits into from
Closed

Hide resource visibility if user is not in defined group #856

wants to merge 3 commits into from

Conversation

lukasfrank
Copy link
Member

@lukasfrank lukasfrank commented Sep 13, 2023 •
edited
Loading

Proposed Changes

  • Added pool-status-view-allowed-groups flag to api-server to define groups which can unhide the pool resources
  • If pool-status-view-allowed-groups is empty every user can see pool resources

Fixes #813

@github-actions github-actions bot added enhancement New feature or request size/L labels Sep 13, 2023
@lukasfrank lukasfrank force-pushed the enh/pool-resource-visibility branch 2 times, most recently from 06f85fa to 28a4367 Compare September 13, 2023 13:07
@lukasfrank lukasfrank marked this pull request as ready for review September 14, 2023 08:42
@lukasfrank lukasfrank requested a review from a team as a code owner September 14, 2023 08:42
afritzler
afritzler requested changes Sep 18, 2023
View reviewed changes
internal/rbac/rbac.go Outdated Show resolved Hide resolved
internal/app/apiserver/apiserver.go Outdated Show resolved Hide resolved
internal/app/compute_test.go Outdated Show resolved Hide resolved
internal/app/storage_test.go Outdated Show resolved Hide resolved
@adracus
Copy link
Contributor

adracus commented Sep 22, 2023

Can we have this concept in a more extensible way?

  • Currently, via this flag, all pools are affected - fine grained control is not possible / extending this to other resources requires lots of coding and flag-passing again
  • The white-out happens after the fields are deserialized - can't we somehow enhance the individual codecs to respect custom tags in the struct definition to avoid iterating over the result objects again?

@afritzler
Copy link
Member

@adracus how about using a SubResource for the pool capacity information? That way we can restrict the access via k8s RBAC and don't have to fiddle around in the Status on a per field level who is allowed to see what.

@afritzler afritzler requested a review from a team as a code owner May 16, 2024 15:58
@lukasfrank lukasfrank closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler Awaiting requested review from afritzler

Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit visibility of <Pool>.Status.Capacity / Allocatable
3 participants
@lukasfrank @adracus @afritzler