Fix Network re-creation in machinebroker
#886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
changed the title
machinebrokerNetwork re-creation in machinebroker
lukasfrank
approved these changes
Oct 16, 2023
afritzler
changed the title
Network re-creation in machinebrokerNetwork re-creation in machinebroker
Remove the network provider ID from the waiters map once an emit successuflly finished. This solves the problem that in case the network has been removed (e.g. via network GC controller), it is never recreated. This causes a problem when brokering machine and NIC resources as the OwnerRef can not be set on a non existing network resource.
afritzler
force-pushed
the
fix/broker-network-recreation
branch
from
56a4f68
to
e9b6b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove the network provider ID from the waiters map once an emit successuflly finished. This solves the problem that in case the
Networkhas been removed (e.g. via network GC controller), it is never recreated. This causes a problem when brokeringMachineandNICresources as the OwnerRef can not be set on a non existingNetworkresource.