Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple ServerClaims claiming same Server object #158

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix multiple ServerClaims claiming same Server object #158

merged 1 commit into from
Oct 30, 2024

Conversation

afritzler
Copy link
Member

Proposed Changes

Restructure the Server claiming flow in the ServerClaim reconciler causing a potential race in which multipl ServerClaims are claiming the same Server object.

@afritzler afritzler requested a review from defo89 October 30, 2024 14:39
@github-actions github-actions bot added bug Something isn't working size/S labels Oct 30, 2024
@afritzler afritzler merged commit 4fe9dfc into main Oct 30, 2024
8 checks passed
@afritzler afritzler deleted the fix/serverclaim branch October 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defo89 defo89 defo89 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afritzler @defo89