Add drives and volumes to server.status.storages
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api-change
documentation
afritzler
requested changes
Nov 5, 2024
bmc/bmc.go
Outdated
| Entity | ||
| State common.State `json:"state,omitempty"` | ||
| // Description provides a description of this resource. | ||
| Description string `json:"description,omitempty"` |
There was a problem hiding this comment.
Do we really wan to have a description field in the status? Where is this information coming from and what should the controller do with this information? Or is it just for the information of the user?
There was a problem hiding this comment.
just in case vendors put some useful information in there ;)
can be removed
There was a problem hiding this comment.
Lets keep this out for now. We can always add fields. Removing is always a pain.
There was a problem hiding this comment.
it is anyway not in the server crd api, just our internal bmc storage structure.
afritzler
changed the title
drives and volumes to server.status.storages
|
Can you please add some PR comments describing the proposed status change? |
afritzler
reviewed
Nov 5, 2024
afritzler
approved these changes
Nov 5, 2024
afritzler
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In redfish storage controllers are made up of volumes and drives.
This change reflects this structure and shows all drives and volumes of each storage available on this server