Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Remove unused VirtualFunction fields #54

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

vlorinc
Copy link
Contributor

@vlorinc vlorinc commented Dec 15, 2023

Removed VirtualFunction fields that are not used anymore.
Requested in issue 444.

These fields are not used in metalnet, only in dpservice-cli (will be updated after merge).

@vlorinc vlorinc requested a review from guvenc December 15, 2023 11:45
@vlorinc vlorinc self-assigned this Dec 15, 2023
@vlorinc vlorinc requested a review from a team as a code owner December 15, 2023 11:45
@github-actions github-actions bot added size/S enhancement New feature or request labels Dec 15, 2023
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@guvenc guvenc merged commit 77ee918 into main Dec 20, 2023
5 of 6 checks passed
@guvenc guvenc deleted the feature/remove_unused_fields branch December 20, 2023 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop referencing those fields in dpservice-cli and dpservice-go (@vlorinc)
2 participants