Port #190 from 2.4 #206
Port #190 from 2.4 #206
Conversation
|
I'll give this a test after lunch |
|
|
||
| // As per https://learn.microsoft.com/en-us/openspecs/windows_protocols/MS-OLEPS/4177a4bc-5547-49fe-a4d9-4767350fd9cf | ||
| // the property names have to be unique, and are case insensitive. | ||
| if (PropertyNames.Any(property => property.Value.Equals(name, StringComparison.InvariantCultureIgnoreCase))) |
There was a problem hiding this comment.
This is causing a 'PropertyNames might be null' warning, though it should never be null in a UserDefinedProperties container since #117
There was a problem hiding this comment.
@Numpsy Thanks for the review! I enabled nullability warnings for 3.0. The warnings here look legitimate, since PropertyNames isn't initialized in the constructor. I did the least amount of work to satisfy the compiler - i.e. I added the missing attributes rather than fixed the initialization. If you want to fix up the nullability attributes/initialization accordingly in a later commit, then that would be great. You'd know much more about the expectations about whether something should/shouldn't be allowed to be null - I've merely enabled the enforcement :)
No description provided.