Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ashish.json #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Ashishkumar448
Copy link

added my domain

@Ashishkumar448 Ashishkumar448 requested a review from a team as a code owner January 28, 2025 10:32
Comment on lines 9 to 18
"A": ["1.1.1.1", "1.0.0.1"],
"AAAA": ["2606:4700:4700::1111", "2606:4700:4700::1001"],
"CNAME": "example.com",
"MX": ["mx1.example.com", "mx2.example.com"],
"TXT": ["example_verification=1234567890"],
"NS": ["ns1.example.com", "ns2.example.com"],
"SRV": [
{ "priority": 10, "weight": 60, "port": 5060, "target": "sipserver.example.com" },
{ "priority": 20, "weight": 10, "port": 5061, "target": "sipbackup.example.com" }
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro these are just the example we have for our service, please use the corresponding records for your website.

@iostpa iostpa added the invalid records You either used invalid records or used a local IP. label Jan 28, 2025
Comment on lines 9 to 17
"A": ["185.199.108.153", "185.199.109.153", "185.199.110.153", "185.199.111.153"],
"AAAA": ["2606:4700:4700::1111", "2606:4700:4700::1001"],
"CNAME": "https://ashishkumar448.github.io/portfolio",
"MX": ["mx1.https://ashishkumar448.github.io/portfolio", "mx2.https://ashishkumar448.github.io/portfolio"],
"TXT": ["google-site-verification=abc123def456"],
"NS": ["ns1.https://ashishkumar448.github.io/portfolio", "ns2.https://ashishkumar448.github.io/portfolio"],
"SRV": [
{ "priority": 10, "weight": 60, "port": 5060, "target": "sipserver.https://ashishkumar448.github.io/portfolio" },
{ "priority": 20, "weight": 10, "port": 5061, "target": "sipbackup.https://ashishkumar448.github.io/portfolio" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...
Just pick either A records for CNAME (remove https:// and /portfolio if you choose CNAME though)

Copy link
Author

@Ashishkumar448 Ashishkumar448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done the changes

Comment on lines 9 to 18
"A": ["185.199.108.153", "185.199.109.153", "185.199.110.153", "185.199.111.153"],
"AAAA": ["2606:4700:4700::1111", "2606:4700:4700::1001"],
"CNAME": "ashishkumar448.github.io",
"MX": ["mx1.https://ashishkumar448.github.io/portfolio", "mx2.https://ashishkumar448.github.io/portfolio"],
"TXT": ["google-site-verification=abc123def456"],
"NS": ["ns1.https://ashishkumar448.github.io/portfolio", "ns2.https://ashishkumar448.github.io/portfolio"],
"SRV": [
{ "priority": 10, "weight": 60, "port": 5060, "target": "sipserver.https://ashishkumar448.github.io/portfolio" },
{ "priority": 20, "weight": 10, "port": 5061, "target": "sipbackup.https://ashishkumar448.github.io/portfolio" }
]
Copy link
Member

@iostpa iostpa Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do this smh, you completely missed my message

Suggested change
"A": ["185.199.108.153", "185.199.109.153", "185.199.110.153", "185.199.111.153"],
"AAAA": ["2606:4700:4700::1111", "2606:4700:4700::1001"],
"CNAME": "ashishkumar448.github.io",
"MX": ["mx1.https://ashishkumar448.github.io/portfolio", "mx2.https://ashishkumar448.github.io/portfolio"],
"TXT": ["google-site-verification=abc123def456"],
"NS": ["ns1.https://ashishkumar448.github.io/portfolio", "ns2.https://ashishkumar448.github.io/portfolio"],
"SRV": [
{ "priority": 10, "weight": 60, "port": 5060, "target": "sipserver.https://ashishkumar448.github.io/portfolio" },
{ "priority": 20, "weight": 10, "port": 5061, "target": "sipbackup.https://ashishkumar448.github.io/portfolio" }
]
"CNAME": "ashishkumar448.github.io"

Copy link
Author

@Ashishkumar448 Ashishkumar448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done the changes

@iostpa
Copy link
Member

iostpa commented Jan 30, 2025

You know, you are keep doing the absolute opposite of what I suggested.
Remove all other records except for CNAME or A records, your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid records You either used invalid records or used a local IP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants