Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create mcalec.is-not.cool #59

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Create mcalec.is-not.cool #59

merged 5 commits into from
Feb 12, 2025

Conversation

McAlec1
Copy link
Contributor

@McAlec1 McAlec1 commented Feb 9, 2025

Create mcalec.json and GitHub Pages verification.

@McAlec1 McAlec1 requested a review from a team as a code owner February 9, 2025 08:32
iostpa
iostpa requested changes Feb 10, 2025
View reviewed changes
domains/mcalec.json Outdated Show resolved Hide resolved
@iostpa iostpa added the invalid This doesn't seem right label Feb 10, 2025
@McAlec1 @iostpa
Update mcalec.json
869b7df 
Co-authored-by: iostpa <[email protected]>
@McAlec1 McAlec1 requested a review from iostpa February 11, 2025 23:24
iostpa
iostpa requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@iostpa iostpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after you fix that it should be fine now

domains/mcalec.json Outdated Show resolved Hide resolved
iostpa
iostpa requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@iostpa iostpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot our config is a little bit weird with TXT

domains/_github-pages-challenge-mcalec-dev.mcalec.json Outdated Show resolved Hide resolved
@McAlec1
Copy link
Contributor Author

McAlec1 commented Feb 12, 2025

alright i will push the change, im on mobile so it might take a second.

iostpa
iostpa approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@iostpa iostpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now its good

@iostpa iostpa removed the invalid This doesn't seem right label Feb 12, 2025
@iostpa iostpa merged commit 53363ba into is-not-cool:main Feb 12, 2025
3 checks passed
@McAlec1
Copy link
Contributor Author

McAlec1 commented Feb 12, 2025

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iostpa iostpa iostpa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McAlec1 @iostpa