-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing instruction ending with "?" fails to parse #233
Comments
arista
added a commit
to arista/sax-js
that referenced
this issue
May 15, 2018
Recognizes "?" while in the PROC_INST_ENDING state, and keeps it in that state after adding "?" to the body
arista
added a commit
to arista/sax-js
that referenced
this issue
May 15, 2018
This reverts commit fe3ed63.
arista
added a commit
to arista/sax-js
that referenced
this issue
May 15, 2018
Recognizes "?" while in the PROC_INST_ENDING state, and keeps it in that state after adding "?" to the body
arista
added a commit
to noteflight/sax-js-NFfork
that referenced
this issue
Jun 12, 2018
This is the fix for isaacs#233 , but fixed in our fork of the https://github.com/isaacs/sax-js repo since that repo doesn't seem to be getting any attention. The equivalent PR in that repo is isaacs#234 - I've just copied the code here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a legal XML construct:
<?Is this legal XML??>
But the parser gets tripped up by the
??
at the end - it doesn't treat the final?>
as the end of the PI, but instead keeps adding to the PI body until it either reaches the end of the file, or the ending?>
of the next PI.The text was updated successfully, but these errors were encountered: