Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial version of chapter 5 #14

Merged
merged 5 commits into from
Dec 15, 2024
Merged

initial version of chapter 5 #14

merged 5 commits into from
Dec 15, 2024

Conversation

sippsack
Copy link
Contributor

No description provided.

@sippsack sippsack requested review from dret and thfro November 20, 2024 23:26
@sippsack sippsack self-assigned this Nov 20, 2024
@sippsack sippsack linked an issue Nov 20, 2024 that may be closed by this pull request
chapter 5 initial version #10
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Build Successful! You can find a link to the downloadable artifacts below.

Name Link
Commit 37daff5
Logs https://github.com/isaqb-org/curriculum-api/actions/runs/12338129100
Download https://github.com/isaqb-org/curriculum-api/suites/32080476623/artifacts/2322592648

@sippsack sippsack changed the title #10 initial version of chapter 5 initial version of chapter 5 Nov 21, 2024
dret
dret approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@dret dret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

thfro
thfro approved these changes Nov 22, 2024
View reviewed changes
Copy link

@thfro thfro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte Kommentare berücksichtigen, ansonsten approved.

@dret
Copy link
Contributor

dret commented Dec 10, 2024

@sippsack, das kann jetzt glaube ich einfach gemerged werden.

@sippsack sippsack merged commit cfb13df into main Dec 15, 2024
1 check passed
@sippsack sippsack mentioned this pull request Dec 15, 2024
Closed
@sippsack sippsack deleted the 10-chapter-5-initial-version branch February 19, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dret dret dret approved these changes

@thfro thfro thfro approved these changes

Assignees

@sippsack sippsack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chapter 5 initial version
3 participants
@sippsack @dret @thfro