Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust LG headings to new format #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adjust LG headings to new format #14

wants to merge 3 commits into from
+44 −56

Conversation

mikesperber
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Build Successful! You can find a link to the downloadable artifacts below.

Name Link
Commit 5b2fbf0
Logs https://github.com/isaqb-org/curriculum-fm/actions/runs/12951838554
Download https://github.com/isaqb-org/curriculum-fm/suites/33481435001/artifacts/2481293377

programming-wolf
programming-wolf requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@programming-wolf programming-wolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you changed from Chicago(?) based style to a sentence like style, where only the first letter is a capital letter?

docs/02-module-block-2/02-learning-goals.adoc Outdated Show resolved Hide resolved
docs/02-module-block-2/02-learning-goals.adoc Outdated Show resolved Hide resolved
docs/03-module-block-3/02-learning-goals.adoc
@@ -31,20 +31,20 @@ tbd.
methods.

[[LG-3-2]]
==== LG 3-2: Relevant Qualities
==== LG 3-2: Know relevant qualities

* Know the qualities that typically indicate the use of formal
methods, such as reliability, safety, and security.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these qualities of ISO25010? Then you should mention it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are, but I disagree - ISO 25010 has no special status in Foundation, either, and mentioning ISO 25010 would add no useful information.

docs/03-module-block-3/02-learning-goals.adoc Outdated Show resolved Hide resolved
docs/04-module-block-4/02-learning-goals.adoc Outdated Show resolved Hide resolved
@mikesperber
Copy link
Contributor Author

Is there a reason why you changed from Chicago(?) based style to a sentence like style, where only the first letter is a capital letter?

The "new" headings are now half-sentences, so I changed to a sentence-like style. Should I go back to capitalization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@programming-wolf programming-wolf Awaiting requested review from programming-wolf

@larsrh larsrh Awaiting requested review from larsrh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikesperber @larsrh @programming-wolf