Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#461 fix non gendered role names #463

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

gernotstarke
Copy link
Member

No description provided.

@gernotstarke gernotstarke requested review from sippsack and alxlo July 10, 2024 18:52
@gernotstarke gernotstarke self-assigned this Jul 10, 2024
Copy link
Contributor

@sippsack sippsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I have two little concerns.

docs/03-design/LZ-03-03.adoc Show resolved Hide resolved
docs/02-requirements/LZ-02-01.adoc Show resolved Hide resolved
Copy link
Member Author

@gernotstarke gernotstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your suggestion "Testmanagement" sounds ok for me (although I'd prefer the shorter "Test"... but if that doesn't resonate with you, let's go for the longer term)

alxlo
alxlo previously approved these changes Jul 24, 2024
@gernotstarke gernotstarke dismissed alxlo’s stale review July 24, 2024 05:48

The merge-base changed after approval.

@gernotstarke gernotstarke dismissed programming-wolf’s stale review July 24, 2024 08:52

The merge-base changed after approval.

@gernotstarke gernotstarke dismissed programming-wolf’s stale review July 24, 2024 13:07

The merge-base changed after approval.

@gernotstarke gernotstarke merged commit 9416e36 into main Jul 24, 2024
1 check passed
@gernotstarke gernotstarke deleted the #461-non-gendered-role-names branch July 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants