-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#564 lg 03 07 interface characteristics #639
Conversation
Build Successful! You can find a link to the downloadable artifacts below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate the two changes.
I am fine with the resolution of the original issue (interface characteristics), but the documentation of quality requirements is a completely different issue.
And I, like Daniel, definitely do not agree that a decision was made regarding this latter issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mit der "hohen Bedeutung" hätte ich noch etwas Formulierungsbauchschmerzen. Ansonsten finde ich die Änderungen ganz gut. Die Systematiserung der Charakteristika ist sicher nicht vollendet, aber gut genug.
I took the liberty of slightly updated the wording again: 1.) the introductory paragraph.DE:
EN:
2. First sectionwe had "know desired characteristics" .... and then "and use these in their design". new version: DE:
EN:
In addition, I changed "festlegen" to "spezifizieren" in the DE version. |
The merge-base changed after approval.
The merge-base changed after approval.
I'm fine with these changes, but the changes are blocked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I like the ADR. 👍 (eat your own dog food)
The merge-base changed after approval.
It should better be called "drink your own champagne", a little less disgusting ... I guess @sippsack referred to the ongoing recital of "use ADRs to document architectural decisions" - and we used an ADR ourselves to document OUR decision... |
shall I open a NEW PR with ONLY the interface-related change in it? |
@kraemerdr https://en.wikipedia.org/wiki/Eating_your_own_dog_food I thought the ADR belongs to this PR. I didn't recognize that it belongs somewhere else. |
@sippsack I know the phrase, of course, but was wondering what the 'dog food' actually is here. If you meant ADRs in general, that makes perfect sense. ;-) |
I close this one, as the many changes are too difficult to track. I have opened a new PR #659 on a fresh branch |
looking for feedback