Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first try of an ADR covering concerns and concepts #647

Closed

Conversation

gernotstarke
Copy link
Member

first try to define an ADR for concerns and concepts

@gernotstarke gernotstarke added V2025 Release 2025 documentation Documentation of any kind, e.g. for style, process, members etc labels Oct 13, 2024
@gernotstarke gernotstarke self-assigned this Oct 13, 2024
Copy link
Contributor

Build Successful! You can find a link to the downloadable artifacts below.

Name Link
Commit c347166
Logs https://github.com/isaqb-org/curriculum-foundation/actions/runs/11317301839
Download https://github.com/isaqb-org/curriculum-foundation/suites/29564302098/artifacts/2050699516

Copy link
Contributor

@rhoadesre rhoadesre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in the following issues:
#15, #299 , #396 , #539 , and most recently in #597

@gernotstarke
Copy link
Member Author

@rhoadesre What is your specific proposal for this PR?

See comments in the following issues: #15, #299 , #396 , #539 , and most recently in #597

e.g. #597 is about quality requirements, not about concerns and concepts.

@rhoadesre
Copy link
Contributor

@rhoadesre What is your specific proposal for this PR?

See comments in the following issues: #15, #299 , #396 , #539 , and most recently in #597

e.g. #597 is about quality requirements, not about concerns and concepts.

As far as I can tell, your ADR is about quality requirements and not cross-cutting concerns. Therefore, I made the reference to #597. My concrete proposal for changes regarding quality requirements is stated in #597. I would like to separate the ADR related to quality requirements from the changes for cross-cutting concerns.

The changes made to the curriculum for the cross-cutting concerns and concepts are good.

@gernotstarke gernotstarke added the wontfix This will not be worked on label Oct 14, 2024
@gernotstarke
Copy link
Member Author

oops - the wrong file made it to the change list - my fault. I make a new PR with the correct ADR... sorry for the hassle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation of any kind, e.g. for style, process, members etc V2025 Release 2025 wontfix This will not be worked on
Projects
Status: Done / Implemented
Development

Successfully merging this pull request may close these issues.

2 participants