Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and Implement ADR012 for Citation Key Standardization #672

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Add and Implement ADR012 for Citation Key Standardization #672

merged 1 commit into from
Nov 10, 2024

Conversation

alxlo
Copy link
Contributor

@alxlo alxlo commented Nov 10, 2024

  • Provide an ADR for consistent citation keys
  • Applied to existing bibliography
  • Provide short section in README

@alxlo
Add and Implement ADR012 for Citation Key Standardization
a1c3da4 
- Provide an ADR for consistent citation keys
- Applied to existing bibliography
- Provide short section in README
@github-actions GitHub Actions
Copy link
Contributor

Build Successful! You can find a link to the downloadable artifacts below.

Name Link
Commit a1c3da4
Logs https://github.com/isaqb-org/curriculum-foundation/actions/runs/11760745575
Download https://github.com/isaqb-org/curriculum-foundation/suites/30703381917/artifacts/2167415122

@alxlo alxlo mentioned this pull request Nov 10, 2024
Closed
@alxlo alxlo requested review from ulibecker and rhoadesre November 10, 2024 11:56
skogsbaer
skogsbaer reviewed Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@skogsbaer skogsbaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great standard for citation keys. I have one small question.

documentation/decisions/012-citation_key_standardization.md Show resolved Hide resolved
@gernotstarke gernotstarke added enhancement V2025 Release 2025 documentation Documentation of any kind, e.g. for style, process, members etc labels Nov 10, 2024
@gernotstarke gernotstarke merged commit 4aeb8d8 into main Nov 10, 2024
1 check passed
@gernotstarke gernotstarke deleted the consistent-citation-keys branch November 10, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsbaer skogsbaer skogsbaer left review comments

@gernotstarke gernotstarke gernotstarke approved these changes

@programming-wolf programming-wolf Awaiting requested review from programming-wolf

@ulibecker ulibecker Awaiting requested review from ulibecker

@rhoadesre rhoadesre Awaiting requested review from rhoadesre

Assignees
No one assigned
Labels
documentation Documentation of any kind, e.g. for style, process, members etc enhancement V2025 Release 2025
Projects
V-2025
Status: Done / Implemented
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxlo @skogsbaer @gernotstarke