Some tweaks to LegoCharacterManager
#1305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetActorROI
usedoperator==
and aconst_iterator
. I'm thinking about ways we can identify blocks of these template functions all at once in BETA10 because many have identical structures. (In Ghidra, use Search > For Matching Instructions > Exclude Operands).FindChildROI
has the iterator constructed outside of the loop.else
.FUN_100849a0
: Arg namep_texture
confirmed by assert.The next thing I want to try is separating the first entry of
g_actorLODs
from the rest of the list. The loop inLegoCharacterManager::SwitchColor
suggests that this may be correct in the beta.