Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks to LegoCharacterManager #1305

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

disinvite
Copy link
Contributor

  • GetActorROI used operator== and a const_iterator. I'm thinking about ways we can identify blocks of these template functions all at once in BETA10 because many have identical structures. (In Ghidra, use Search > For Matching Instructions > Exclude Operands).
  • FindChildROI has the iterator constructed outside of the loop.
  • Beta shows that many functions here have an unnecessary final else.
  • FUN_100849a0: Arg name p_texture confirmed by assert.

The next thing I want to try is separating the first entry of g_actorLODs from the rest of the list. The loop in LegoCharacterManager::SwitchColor suggests that this may be correct in the beta.

@foxtacles
Copy link
Member

I think the type LegoTextureInfo* has been introduced after the BETA - before that, it was LegoTexture* iirc. That's why I also renamed the parameter to avoid the confusion between the two. I wouldn't mind keeping the name in p_texture though, just wanted to mention it. Looks good!

@disinvite
Copy link
Contributor Author

Well, no problem to change it back if you think it's better the old way. It's more clear as p_textureInfo. I don't know if assert matching is a priority or is even possible.

@foxtacles foxtacles merged commit 70e72de into isledecomp:master Dec 30, 2024
12 checks passed
@disinvite disinvite deleted the charactermanager1 branch December 30, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants