introduce Docker as a compilation method #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I frequently get asked if it's possible to build the project on Linux and macOS hosts. It always has been possible; many contributors have used and do use a workflow with Wine on non-Windows platforms, but the manual configuration for this setup has never been officially documented and is a bit cumbersome. I've been thinking about ways to address this over the course of the project, but I haven't sat down and fleshed it out until now.
This PR introduces Docker as a method of compilation. I've written a
Dockerfileand accompanying shell script to create a Docker image that has MSVC 4.20 and CMake pre-configured properly with Wine under Debian. I've already built the image and pushed it toghcr.iounder our organization, so all end users have to do to build the project under Linux and macOS hosts is to use our provideddocker runcommand, where they can simply pass paths and CMake flags to the container.Let me know if anyone has any objections or questions!