Fix mypy compliance in Ghidra scripts
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonschz
commented
Jan 11, 2025
Comment on lines
+110
to
+112
| from reccmp.ghidra_scripts.lego_util.globals import GLOBALS | ||
|
|
||
| logging.root.setLevel(GLOBALS.loglevel) |
There was a problem hiding this comment.
This had to be reordered because we can't import GLOBALS before setting up the venv now. On the other hand, mypy doesn't allow me to import from lego_util.globals because the package can be referenced by two different paths.
disinvite
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic type safety should now be complete.