Revert "Use DUCT-TAPE to fix irq test" #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2e0f9ff. Signed-off-by: Michał Szaknis <[email protected]>
L0czek
force-pushed
the
dev/m.szaknis/revert_irq
branch
from
2d1be7a to
4eb14ff
Compare
|
I've verified that the #350 is fixed with that commit. From my understanding reverting 2e0f9ff means that one of ACS tests will start to fail again, but it's of a less importance that being able to fetch the token and perform attestation. @L0czek please make a note here what github issues is tracking this stuff. |
Havner
approved these changes
Jul 19, 2024
This issue is tracked in #352 at
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2e0f9ff.
It appears that some (maybe Islet) is not handling some IRQ properly. As a result this patch broke reading the attestation token even though the cca-rmm-acs tests were passing. It it most likely due to the fact that the test suite was a simple bare metal binary that doesn't utilize much of the emulated hardware. Reverting this patch doesn't remove any functionality. In the future, the IRQ handling should be investigated.